Adding FSDP Support to Training Library #213
Conversation
aldopareja
force-pushed
the
ap/accelerate-fsdp-tmp2
branch
from
560c2ec
to
0b4d516
Compare
mergify
bot
added
ci-failure
dependencies
Maxusmusti
changed the title
mergify
bot
added
ci-failure
CI/CD
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Oleg S <97077423+RobotSail@users.noreply.github.com>
mergify
bot
added
documentation
…ining_backend to TrainingArgs.distributed_backend and DistributedTrainingBackend to DistributedBackend Signed-off-by: Oleg S <97077423+RobotSail@users.noreply.github.com>
RobotSail
force-pushed
the
ap/accelerate-fsdp-tmp2
branch
from
e2b4ae4
to
95eb2c0
Compare
Signed-off-by: Mustafa Eyceoz <meyceoz@redhat.com>
Signed-off-by: Mustafa Eyceoz <meyceoz@redhat.com>
| @@ -157,6 +181,12 @@ class TrainingArgs(BaseModel): | |||
| cpu_offload_optimizer_pin_memory=False, | |||
| ) | |||
| ) | |||
| fsdp_options: FSDPOptions = Field( | |||
There was a problem hiding this comment.
does this need to be a factory? I think it can just be an assignment
There was a problem hiding this comment.
I'm following the current convention set by DeepSpeedOptions in the file, so imo if we want to change this, we should make a follow-up PR that updates both of them
| reduce_dtype=torch.bfloat16, | ||
| buffer_dtype=torch.bfloat16, | ||
| ), | ||
| backward_prefetch=BackwardPrefetch.BACKWARD_PRE, |
There was a problem hiding this comment.
Do we want to expose this ever? This adds a bit of memory overhead for some performance- I think customarily it's probably a default.
There was a problem hiding this comment.
This is a good point, I think it's fine for now, but I will open an issue to track this, as I'm not sure how much of a performance hit compared to memory gain this option will be for us. Might be a nice bonus trick to avoid offloading in some configurations if performance isn't horrendous
src/instructlab/training/main_ds.py
Outdated
| } | ||
| return ds_config | ||
| def setup_optimizer(args, model): | ||
| if args.distributed_training_framework == "fsdp": |
There was a problem hiding this comment.
The typical way to do this is via this pattern:
| if args.distributed_training_framework == "fsdp": | |
| if DistributedBackend(args.distributed_training_framework) == DistributedBackend.FSDP: |
This collects "magic strings" like "fsdp" would be into the Enum object.
There was a problem hiding this comment.
Note: it actually has to be DistributedBackend.FSDP.value, since by this point the args have gone through the main_ds argparse post-torchrun and args.distributed_training_framework is just a string
src/instructlab/training/main_ds.py
Outdated
| model.parameters(), lr=args.learning_rate, betas=(0.9, 0.95) | ||
| ) | ||
| accelerator = setup_accelerator(args, model, grad_accum) | ||
| if args.distributed_training_framework == "fsdp": |
There was a problem hiding this comment.
Note: it actually has to be DistributedBackend.FSDP.value, since by this point the args have gone through the main_ds argparse post-torchrun and args.distributed_training_framework is just a string
| ), | ||
| lr_scheduler=lr_scheduler, | ||
| dist_init_required=True, | ||
| model, optimizer, _, lr_scheduler = accelerator.prepare( |
There was a problem hiding this comment.
I see here that we're "double preparing" the model- is that okay? Is Accelerate smart enough to handle this?
There was a problem hiding this comment.
Yes, I have verified that it is, originally I had some conditionals to avoid it but accelerate was one step ahead
| global_grad_norm = accelerator.clip_grad_norm_(model.parameters(), 1.0) | ||
| optimizer.step() | ||
| lr_scheduler.step() | ||
| optimizer.zero_grad() |
There was a problem hiding this comment.
I haven't seen this here conventionally, only at the top of the training loop. I guess it can be either place. I also see that this is where they put it in the docs.
Signed-off-by: Mustafa Eyceoz <meyceoz@redhat.com>
Adds support for FSDP and FSDP w/ CPU Offloading.
Introduces accelerate as a distributed backend abstraction (for FSDP/DeepSpeed)
Also fixes mistral template and cleans up data processing.
-Mustafa